Re: [PATCH] netfilter: nat: remove rcu_read_lock in __nf_nat_decode_session.

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Tue, Mar 28, 2017 at 12:28:50AM +0900, Taehee Yoo wrote:
> __nf_nat_decode_session is called from nf_nat_decode_session as decodefn.
> before calling decodefn, it already set rcu_read_lock. so rcu_read_lock in
> __nf_nat_decode_session can be removed.

Could you have close look at the tree to confirm if we have more spots
where rcu_read_lock is unnecessary?

$ git grep rcu_read_lock net/netfilter/ | wc -l
158
$ git grep rcu_read_lock
net/ipv4/netfilter/ | wc -l
3
$ git grep rcu_read_lock
net/ipv6/netfilter/ | wc -l
2
$ git grep rcu_read_lock
net/bridge/netfilter/ | wc -l

It's a fair good amount, it would take me around one hour probably to
evaluate those here.

If you can help us on verifying this, it would be simply great.

Thanks!