From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] tests: nft removes required payload protocol expressions
Date: Fri, 7 Apr 2017 00:50:26 +0200 [thread overview]
Message-ID: <20170406225026.GA2663@salvia> (raw)
In-Reply-To: <20170406184547.GA10969@breakpoint.cc>
On Thu, Apr 06, 2017 at 08:45:47PM +0200, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Thu, Mar 23, 2017 at 09:11:56AM +0100, Florian Westphal wrote:
> > > This test fails with
> > > 'ip protocol tcp tcp dport 22' mismatches 'tcp dport 22'
> > >
> > > ip protocol tcp tcp dport 22 is *ONLY* identical to
> > > 'tcp dport 22' in the ip family.
> > >
> > > For netdev/inet/bridge, the dependency is required because
> > > we only want to match ipv4 packets.
> >
> > This needs the C chunk to fix this, right? so I let you decide if you
> > want to push out this test now or make it together with the fix.
>
> I have no fix at the moment.
>
> I will thus probably push this test when I get home so we don't forget
> about it.
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Thanks!
prev parent reply other threads:[~2017-04-06 22:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 8:11 [PATCH nft] tests: nft removes required payload protocol expressions Florian Westphal
2017-04-06 16:41 ` Pablo Neira Ayuso
2017-04-06 18:45 ` Florian Westphal
2017-04-06 22:50 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170406225026.GA2663@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).