From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] exthdr: avoid crash with older kernels
Date: Fri, 7 Apr 2017 00:55:06 +0200 [thread overview]
Message-ID: <20170406225506.GB2867@salvia> (raw)
In-Reply-To: <20170404184646.16038-1-fw@strlen.de>
On Tue, Apr 04, 2017 at 08:46:46PM +0200, Florian Westphal wrote:
> if kernel is older it won't understand the EXTHDR_OP attribute, i.e.
> the rule gets accepted as a check for ipv6 exthdr.
>
> On dump nft is then presented with a invalid ipv6 exthdr.
> So we need to get rid of the assert and output an "invalid" message on
> list. Longterm we need a proper vm description or kernel-side check
> to reject such messages in first place.
>
> After patch, test suite yields erros of type
> ip6/tcpopt.t: WARNING: 'src/nft add rule --debug=netlink ip6 test-ip6 \
> input tcp option sack right 1': 'tcp option sack right 1' mismatches
> 'ip6 nexthdr 6 unknown-exthdr unknown 0x1 [invalid type]'
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
prev parent reply other threads:[~2017-04-06 22:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 18:46 [PATCH nft] exthdr: avoid crash with older kernels Florian Westphal
2017-04-06 22:55 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170406225506.GB2867@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).