From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Pablo M. Bermudo Garay" <pablombg@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH iptables] tests: add regression tests for xtables-translate
Date: Fri, 7 Apr 2017 17:52:31 +0200 [thread overview]
Message-ID: <20170407155231.GA3324@salvia> (raw)
In-Reply-To: <CAAaDf4vZm3dZLuvgHeFV-fqJCCf25vFCuYq_QqR6LWhXX6a+8g@mail.gmail.com>
On Fri, Apr 07, 2017 at 12:46:23PM +0200, Pablo M. Bermudo Garay wrote:
> > Nice... But how this works? :)
> >
> > # python xlate-test.py
> > Traceback (most recent call last):
> > File "xlate-test.py", line 85, in <module>
> > main()
> > File "xlate-test.py", line 78, in main
> > load_test_files()
> > File "xlate-test.py", line 65, in load_test_files
> > run_test(test, payload)
> > File "xlate-test.py", line 43, in run_test
> > output = subprocess.run(shlex.split(line), stdout=subprocess.PIPE)
> > AttributeError: 'module' object has no attribute 'run'
>
> The script is written using python3. The shebang points to the python3
> interpreter, so the script can be executed with ./xlate-test.py or
> python3 xlate-test.py.
This seems to need Python 3.5 specifically, this was breaking here
with Python 3.4 ;)
Anyway I have applied this, but I see tests reporting failures...
Please follow up and fix that seem to be related to your setup:
iptables-translate v1.6.1: label 'bit40' not found
There seem to be also some problems in the current output that cause
mismatches. This may need small fixes to some of the extensions.
I would appreciate if you can follow up and fix those, thanks!
prev parent reply other threads:[~2017-04-07 15:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 12:34 [PATCH iptables] tests: add regression tests for xtables-translate Pablo M. Bermudo Garay
2017-04-06 22:58 ` Pablo Neira Ayuso
2017-04-07 10:48 ` Pablo M. Bermudo Garay
[not found] ` <CAAaDf4vZm3dZLuvgHeFV-fqJCCf25vFCuYq_QqR6LWhXX6a+8g@mail.gmail.com>
2017-04-07 15:52 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407155231.GA3324@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablombg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).