From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH 1/4] net: netfilter:Remove exceptional & on function name Date: Fri, 7 Apr 2017 18:28:33 +0200 Message-ID: <20170407162833.GA10487@salvia> References: <20170402092215.22792-1-arushisinghal19971997@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kadlec@blackhole.kfki.hu, davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Arushi Singhal Return-path: Received: from mail.us.es ([193.147.175.20]:43248 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932598AbdDGQ2j (ORCPT ); Fri, 7 Apr 2017 12:28:39 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 73F3D1373AD for ; Fri, 7 Apr 2017 18:28:35 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 5FE24DA38E for ; Fri, 7 Apr 2017 18:28:35 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 0C2B3DA87B for ; Fri, 7 Apr 2017 18:28:33 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20170402092215.22792-1-arushisinghal19971997@gmail.com> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Sun, Apr 02, 2017 at 02:52:12PM +0530, Arushi Singhal wrote: > Remove & from function pointers to conform to the style found elsewhere > in the file. Done using the following semantic patch > > // > @r@ > identifier f; > @@ > > f(...) { ... } > @@ > identifier r.f; > @@ > > - &f > + f > // I have collapsed these four patches. You only need to send one patch per logical update. I also detected that you missed one spot in nft_hash.c, I manually updated this but next time you have to be more careful. Thanks!