From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arushi Singhal <arushisinghal19971997@gmail.com>
Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ipv6: Removed unnecessary parenthesis
Date: Fri, 7 Apr 2017 18:31:57 +0200 [thread overview]
Message-ID: <20170407163157.GA10529@salvia> (raw)
In-Reply-To: <20170329090243.GA24402@arushi-HP-Pavilion-Notebook>
On Wed, Mar 29, 2017 at 02:32:43PM +0530, Arushi Singhal wrote:
> Removed parentheses on the right hand side of assignment, as they are
> not required. The following coccinelle script was used to fix this
> issue:
>
> @@
> local idexpression id;
> expression e;
> @@
>
> id =
> -(
> e
> -)
You sent me two patches for this:
http://patchwork.ozlabs.org/patch/744661/
http://patchwork.ozlabs.org/patch/744702/
The follow up one does not indicate v2, so I'm confused. I'm not sure
this is a resend or just a new version.
Another question that is not clear from your description is if you had
a look at the entire tree to find more spots like this, or you just
found this one and update it.
Ideally, it would be better to fix everything in one go, so we don't
have to deal with oneliner patches that just fix one single spot.
Thanks!
next prev parent reply other threads:[~2017-04-07 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 9:02 [PATCH] net: ipv6: Removed unnecessary parenthesis Arushi Singhal
2017-04-07 16:31 ` Pablo Neira Ayuso [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-03-29 10:17 Arushi Singhal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407163157.GA10529@salvia \
--to=pablo@netfilter.org \
--cc=arushisinghal19971997@gmail.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).