From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH] net: ipv6: Removed unnecessary parenthesis Date: Fri, 7 Apr 2017 18:31:57 +0200 Message-ID: <20170407163157.GA10529@salvia> References: <20170329090243.GA24402@arushi-HP-Pavilion-Notebook> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jozsef Kadlecsik , "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Arushi Singhal Return-path: Received: from mail.us.es ([193.147.175.20]:44368 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933885AbdDGQcF (ORCPT ); Fri, 7 Apr 2017 12:32:05 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id E63A71373AD for ; Fri, 7 Apr 2017 18:32:00 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id C79CEDA725 for ; Fri, 7 Apr 2017 18:32:00 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id E45B6DA86F for ; Fri, 7 Apr 2017 18:31:56 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20170329090243.GA24402@arushi-HP-Pavilion-Notebook> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Wed, Mar 29, 2017 at 02:32:43PM +0530, Arushi Singhal wrote: > Removed parentheses on the right hand side of assignment, as they are > not required. The following coccinelle script was used to fix this > issue: > > @@ > local idexpression id; > expression e; > @@ > > id = > -( > e > -) You sent me two patches for this: http://patchwork.ozlabs.org/patch/744661/ http://patchwork.ozlabs.org/patch/744702/ The follow up one does not indicate v2, so I'm confused. I'm not sure this is a resend or just a new version. Another question that is not clear from your description is if you had a look at the entire tree to find more spots like this, or you just found this one and update it. Ideally, it would be better to fix everything in one go, so we don't have to deal with oneliner patches that just fix one single spot. Thanks!