From: Pablo Neira Ayuso <pablo@netfilter.org>
To: gfree.wind@foxmail.com
Cc: netfilter-devel@vger.kernel.org, Gao Feng <fgao@ikuai8.com>
Subject: Re: [PATCH nf v3 1/1] netfilter: helper: Add the rcu lock when call __nf_conntrack_helper_find
Date: Sat, 8 Apr 2017 23:08:16 +0200 [thread overview]
Message-ID: <20170408210816.GA5045@salvia> (raw)
In-Reply-To: <1490785887-17732-1-git-send-email-gfree.wind@foxmail.com>
On Wed, Mar 29, 2017 at 07:11:27PM +0800, gfree.wind@foxmail.com wrote:
> From: Gao Feng <fgao@ikuai8.com>
>
> When invoke __nf_conntrack_helper_find, it needs the rcu lock to
> protect the helper module which would not be unloaded.
>
> Now there are two caller nf_conntrack_helper_try_module_get and
> ctnetlink_create_expect which don't hold rcu lock. And the other
> callers left like ctnetlink_change_helper, ctnetlink_create_conntrack,
> and ctnetlink_glue_attach_expect, they already hold the rcu lock
> or spin_lock_bh.
>
> Remove the rcu lock in functions nf_ct_helper_expectfn_find_by_name
> and nf_ct_helper_expectfn_find_by_symbol. Because they return one pointer
> which needs rcu lock, so their caller should hold the rcu lock, not in
> these two functions.
Applied.
prev parent reply other threads:[~2017-04-08 21:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 11:11 [PATCH nf v3 1/1] netfilter: helper: Add the rcu lock when call __nf_conntrack_helper_find gfree.wind
2017-04-08 21:08 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170408210816.GA5045@salvia \
--to=pablo@netfilter.org \
--cc=fgao@ikuai8.com \
--cc=gfree.wind@foxmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).