From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org, cernekee@chromium.org,
Liping Zhang <zlpnobody@gmail.com>
Subject: Re: [PATCH nf] netfilter: ctnetlink: make it safer when checking the ct helper name
Date: Sat, 8 Apr 2017 23:10:30 +0200 [thread overview]
Message-ID: <20170408211030.GA5301@salvia> (raw)
In-Reply-To: <1491051344-29766-1-git-send-email-zlpnobody@163.com>
On Sat, Apr 01, 2017 at 08:55:44PM +0800, Liping Zhang wrote:
> From: Liping Zhang <zlpnobody@gmail.com>
>
> One CPU is doing ctnetlink_change_helper(), while another CPU is doing
> unhelp() at the same time. So even if help->helper is not NULL at first,
> the later statement strcmp(help->helper->name, ...) may still access
> the NULL pointer.
>
> So we must use rcu_read_lock and rcu_dereference to avoid such _bad_
> thing happen.
Applied, thanks.
prev parent reply other threads:[~2017-04-08 21:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 12:55 [PATCH nf] netfilter: ctnetlink: make it safer when checking the ct helper name Liping Zhang
2017-04-08 21:10 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170408211030.GA5301@salvia \
--to=pablo@netfilter.org \
--cc=cernekee@chromium.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
--cc=zlpnobody@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).