From: Pablo Neira Ayuso <pablo@netfilter.org>
To: kbuild test robot <lkp@intel.com>
Cc: Arushi Singhal <arushisinghal19971997@gmail.com>,
kbuild-all@01.org, wensong@linux-vs.org,
Simon Horman <horms@verge.net.au>, Julian Anastasov <ja@ssi.bg>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: netfilter: ipvs: Replace explicit NULL comparison
Date: Mon, 10 Apr 2017 13:53:00 +0200 [thread overview]
Message-ID: <20170410115300.GB2155@salvia> (raw)
In-Reply-To: <201704090633.AKZxFfWl%fengguang.wu@intel.com>
Arushi,
On Sun, Apr 09, 2017 at 06:21:51AM +0800, kbuild test robot wrote:
> Hi Arushi,
>
> [auto build test WARNING on ipvs-next/master]
> [also build test WARNING on v4.11-rc5 next-20170407]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Arushi-Singhal/net-netfilter-ipvs-Replace-explicit-NULL-comparison/20170409-044710
> base: https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs-next.git master
> config: i386-randconfig-x002-201715 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=i386
>
> All warnings (new ones prefixed by >>):
>
> net/netfilter/ipvs/ip_vs_proto.c: In function 'ip_vs_protocol_net_cleanup':
> >> net/netfilter/ipvs/ip_vs_proto.c:350:3: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
> while (pd = ipvs->proto_data_table[i])
> ^~~~~
This is bad, you have to be more careful in what you do. This is not a
speed coding contest.
Showing careful patchset handling, even if you submit less of them, is
way more prefered in my opinion.
prev parent reply other threads:[~2017-04-10 11:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 17:18 [PATCH] net: netfilter: ipvs: Replace explicit NULL comparison Arushi Singhal
2017-04-08 22:21 ` kbuild test robot
2017-04-10 11:53 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410115300.GB2155@salvia \
--to=pablo@netfilter.org \
--cc=arushisinghal19971997@gmail.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kadlec@blackhole.kfki.hu \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).