From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: James Cowgill <James.Cowgill@imgtec.com>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH iptables] extensions: libxt_hashlimit: fix 64-bit printf formats
Date: Tue, 11 Apr 2017 09:00:19 +0200 [thread overview]
Message-ID: <20170411070019.GA2180@salvia> (raw)
In-Reply-To: <nycvar.YFH.7.76.1704101749480.27401@n3.vanv.qr>
On Mon, Apr 10, 2017 at 05:59:07PM +0200, Jan Engelhardt wrote:
>
> On Saturday 2017-04-08 22:29, Pablo Neira Ayuso wrote:
> >> @@ -262,7 +262,7 @@ static uint64_t parse_burst(const char *burst, int revision)
> >> if (v > max)
> >> xtables_error(PARAMETER_PROBLEM, "bad value for option "
> >> "\"--hashlimit-burst\", value \"%s\" too large "
> >> - "(max %lumb).", burst, max/1024/1024);
> >> + "(max %" PRIu64 "mb).", burst, max/1024/1024);
> > ^ ^
> >
> >I can remove this whitespaces, right?
>
> With my distro hat on:
>
> Clumping these together like "foo"BAR"baz" has already caused compile failures
> in the broader scope of distributions (thousands of packages) because languages
> introduced new tokenization rules. Admittedly, this occurred in C++ (namely,
> user-defined string literals), but it does show that tokens which logically are
> separate should stay separate.
Existing code doesn't add space, so I would like we don't introduce
inconsistencies.
prev parent reply other threads:[~2017-04-11 7:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 11:47 [PATCH iptables] extensions: libxt_hashlimit: fix 64-bit printf formats James Cowgill
2017-04-07 12:17 ` Arturo Borrero Gonzalez
2017-04-08 20:29 ` Pablo Neira Ayuso
2017-04-10 9:38 ` James Cowgill
2017-04-10 15:59 ` Jan Engelhardt
2017-04-11 7:00 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411070019.GA2180@salvia \
--to=pablo@netfilter.org \
--cc=James.Cowgill@imgtec.com \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).