From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Vincent Bernat <vincent@bernat.im>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH iptables v1] iptables-restore/save: exit when given an unknown option
Date: Thu, 13 Apr 2017 23:16:27 +0200 [thread overview]
Message-ID: <20170413211627.GA2387@salvia> (raw)
In-Reply-To: <20170403184918.13847-1-vincent@bernat.im>
On Mon, Apr 03, 2017 at 08:49:18PM +0200, Vincent Bernat wrote:
> When an unknown option is given, iptables-restore should exit instead of
> continue its operation. For example, if `--table` was misspelled, this
> could lead to an unwanted change. Moreover, exit with a status code of
> 1. Make the same change for iptables-save.
I was trying to skip this, since this has been working like this since
day 1 and some stupid script may break, but OK, let's fix this.
> OTOH, exit with a status code of 0 when requesting help.
Could you also fix xtables-restore.c that is used for the compat
layer?
Thanks!
next prev parent reply other threads:[~2017-04-13 21:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 18:49 [PATCH iptables v1] iptables-restore/save: exit when given an unknown option Vincent Bernat
2017-04-13 21:16 ` Pablo Neira Ayuso [this message]
2017-04-14 11:56 ` [PATCH iptables v2] " Vincent Bernat
2017-04-15 8:50 ` Pablo Neira Ayuso
2017-04-15 10:16 ` [PATCH iptables v3] " Vincent Bernat
2017-04-19 16:00 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413211627.GA2387@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=vincent@bernat.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).