From: Pablo Neira Ayuso <pablo@netfilter.org>
To: gfree.wind@foxmail.com
Cc: netfilter-devel@vger.kernel.org, Gao Feng <fgao@ikuai8.com>
Subject: Re: [PATCH nf 1/1] netfilter: seqadj: Fix possible non-linear data access for TCP header
Date: Thu, 13 Apr 2017 23:37:05 +0200 [thread overview]
Message-ID: <20170413213705.GA3430@salvia> (raw)
In-Reply-To: <1491820563-98023-1-git-send-email-gfree.wind@foxmail.com>
On Mon, Apr 10, 2017 at 06:36:03PM +0800, gfree.wind@foxmail.com wrote:
> From: Gao Feng <fgao@ikuai8.com>
>
> The current call path of nf_ct_tcp_seqadj_set is the following.
>
> nfqnl_recv_verdict->ctnetlink_glue_hook->ctnetlink_glue_seqadj
> ->nf_ct_tcp_seqadj_set.
>
> It couldn't make sure the TCP header is in the linear data part.
> So use the skb_header_pointer instead of the current codes.
>
> BTW, the nf_ct_tcp_seqadj_set is one external function of netfilter
> which works in the network layer, it should not assume the transport
> header is in the linear data.
Applied.
I wish you fix your mail client setup, it is a mess. I always have to
figure out which patch is correct in the large bunch. You have to be
more careful.
next prev parent reply other threads:[~2017-04-13 21:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 10:36 [PATCH nf 1/1] netfilter: seqadj: Fix possible non-linear data access for TCP header gfree.wind
2017-04-10 12:06 ` Pablo Neira Ayuso
2017-04-11 0:59 ` 高峰
2017-04-11 2:44 ` Gao Feng
2017-04-11 2:47 ` 高峰
2017-04-11 2:53 ` Gao Feng
2017-04-13 21:37 ` Pablo Neira Ayuso [this message]
2017-04-13 21:42 ` Pablo Neira Ayuso
2017-04-13 21:44 ` Pablo Neira Ayuso
2017-04-13 22:17 ` Gao Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413213705.GA3430@salvia \
--to=pablo@netfilter.org \
--cc=fgao@ikuai8.com \
--cc=gfree.wind@foxmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).