From: Pablo Neira Ayuso <pablo@netfilter.org>
To: gfree.wind@foxmail.com
Cc: netfilter-devel@vger.kernel.org, Gao Feng <fgao@ikuai8.com>
Subject: Re: [PATCH nf-next v2 1/1] netfilter: SYNPROXY: Return NF_STOLEN instead of NF_DROP during handshaking
Date: Thu, 13 Apr 2017 23:57:49 +0200 [thread overview]
Message-ID: <20170413215749.GA4208@salvia> (raw)
In-Reply-To: <1491963290-84377-1-git-send-email-gfree.wind@foxmail.com>
On Wed, Apr 12, 2017 at 10:14:50AM +0800, gfree.wind@foxmail.com wrote:
> From: Gao Feng <fgao@ikuai8.com>
>
> Current SYNPROXY codes return NF_DROP during normal TCP handshaking,
> it is not friendly to caller. Because the nf_hook_slow would treat
> the NF_DROP as an error, and return -EPERM.
> As a result, it may cause the top caller think it meets one error.
>
> So use NF_STOLEN instead of NF_DROP now because there is no error
> happened indeed, and free the skb directly.
Is this really addressing a real problem? How did you reproduce it?
BTW, your patch title is wrong.
[PATCH nf-next v2 1/1]
^^^
This 1/1 is completely useless, please remove it in your follow up
patches.
Moreover, you should be more careful, *really*, this is not a speed
coding contest. You tend to send me follow up patch version just hours
afterwards because you rush too much.
Be more careful, use the same email address to send your patches. Drop
quote the full email in your replies...
Other than that, I may start ignoring your patches, it's too hard to
keep up with this.
next prev parent reply other threads:[~2017-04-13 21:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 2:14 [PATCH nf-next v2 1/1] netfilter: SYNPROXY: Return NF_STOLEN instead of NF_DROP during handshaking gfree.wind
2017-04-13 21:57 ` Pablo Neira Ayuso [this message]
2017-04-13 23:04 ` Gao Feng
2017-04-13 23:11 ` Pablo Neira Ayuso
2017-04-14 4:52 ` Gao Feng
2017-04-19 15:57 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413215749.GA4208@salvia \
--to=pablo@netfilter.org \
--cc=fgao@ikuai8.com \
--cc=gfree.wind@foxmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).