From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org, Liping Zhang <zlpnobody@gmail.com>
Subject: Re: [PATCH nf] netfilter: xt_CT: fix cthelper module's refcnt leak
Date: Fri, 14 Apr 2017 00:30:56 +0200 [thread overview]
Message-ID: <20170413223056.GA5106@salvia> (raw)
In-Reply-To: <1491622728-55625-1-git-send-email-zlpnobody@163.com>
On Sat, Apr 08, 2017 at 11:38:48AM +0800, Liping Zhang wrote:
> From: Liping Zhang <zlpnobody@gmail.com>
>
> We should call module_put when the time policy is not found. Otherwise,
> the related cthelper module cannot be removed anymore.
>
> It is easy to reproduce by typing the following command:
> # iptables -t raw -A OUTPUT -p tcp -j CT --helper ftp --timeout xxx
Can we fix all leaks in the error path in one single patch for xt_CT?
Feng sent me a patch to fix another issue there, so if either you or
him send me one single patch to fix all xt_CT refcount leaks in one
go, I'd appreciate.
Thanks.
next prev parent reply other threads:[~2017-04-13 22:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 3:38 [PATCH nf] netfilter: xt_CT: fix cthelper module's refcnt leak Liping Zhang
2017-04-13 22:30 ` Pablo Neira Ayuso [this message]
2017-04-13 23:09 ` Liping Zhang
2017-04-14 0:49 ` Gao Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413223056.GA5106@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
--cc=zlpnobody@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).