From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: netdev@vger.kernel.org, Aaron Conole <aconole@bytheb.org>,
linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next] ipset: remove unused function __ip_set_get_netlink
Date: Fri, 14 Apr 2017 01:28:42 +0200 [thread overview]
Message-ID: <20170413232842.GC7721@salvia> (raw)
In-Reply-To: <20170410195237.19909-1-aconole@bytheb.org>
On Mon, Apr 10, 2017 at 03:52:37PM -0400, Aaron Conole wrote:
> There are no in-tree callers.
@Jozsef, let me know if I should just take this to save you a pull
request.
Thanks.
> Signed-off-by: Aaron Conole <aconole@bytheb.org>
> ---
> net/netfilter/ipset/ip_set_core.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c
> index c296f9b..68ba531 100644
> --- a/net/netfilter/ipset/ip_set_core.c
> +++ b/net/netfilter/ipset/ip_set_core.c
> @@ -501,14 +501,6 @@ __ip_set_put(struct ip_set *set)
> * a separate reference counter
> */
> static inline void
> -__ip_set_get_netlink(struct ip_set *set)
> -{
> - write_lock_bh(&ip_set_ref_lock);
> - set->ref_netlink++;
> - write_unlock_bh(&ip_set_ref_lock);
> -}
> -
> -static inline void
> __ip_set_put_netlink(struct ip_set *set)
> {
> write_lock_bh(&ip_set_ref_lock);
> --
> 2.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-04-13 23:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 19:52 [PATCH nf-next] ipset: remove unused function __ip_set_get_netlink Aaron Conole
2017-04-13 23:28 ` Pablo Neira Ayuso [this message]
2017-04-14 14:15 ` Jozsef Kadlecsik
2017-04-15 8:45 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413232842.GC7721@salvia \
--to=pablo@netfilter.org \
--cc=aconole@bytheb.org \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).