From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Gao Feng <gfree.wind@foxmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf v5 2/3] netfilter: nat_helper: Make sure every proto nat module uses its nat_helper
Date: Fri, 14 Apr 2017 03:02:49 +0200 [thread overview]
Message-ID: <20170414010249.GA29837@salvia> (raw)
In-Reply-To: <000001d2b4b8$97256c40$c57044c0$@foxmail.com>
On Fri, Apr 14, 2017 at 08:46:44AM +0800, Gao Feng wrote:
> > -----Original Message-----
> > From: Pablo Neira Ayuso [mailto:pablo@netfilter.org]
> > On Fri, Mar 31, 2017 at 06:38:20PM +0800, gfree.wind@foxmail.com wrote:
> > > +static struct nf_ct_nat_helper pptp_nat = {
> > > + .name = "pptp_nat",
> >
> > Why all these with "xyz_nat" names?
>
> I just used the variable name before.
> How about rename it to "xyz_nat_helper"?
> >
> > This is going to break ctnetlink, as this is the name that identifies the
> NAT
> > helper to be used.
This name is exposed to userspace, right?
So FTP uses to rely on the "nat-follow-master" expectfn. But now the
name will be "ftp_nat".
If that is the case, this would break backward.
next prev parent reply other threads:[~2017-04-14 1:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 10:38 [PATCH nf v5 0/3] Refine the robust of helper expectfn gfree.wind
2017-03-31 10:38 ` [PATCH nf v5 1/3] netfilter: helper: Rename struct nf_ct_helper_expectfn to nf_ct_nat_helper gfree.wind
2017-03-31 10:38 ` [PATCH nf v5 2/3] netfilter: nat_helper: Make sure every proto nat module uses its nat_helper gfree.wind
2017-04-14 0:11 ` Pablo Neira Ayuso
2017-04-14 0:46 ` Gao Feng
2017-04-14 1:02 ` Pablo Neira Ayuso [this message]
2017-04-17 0:50 ` Gao Feng
2017-03-31 10:38 ` [PATCH nf v5 3/3] netfilter: nat_helper: Remove the expectations when its module is unloaded gfree.wind
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170414010249.GA29837@salvia \
--to=pablo@netfilter.org \
--cc=gfree.wind@foxmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).