From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org, laura.garcia@zevenet.com,
Liping Zhang <zlpnobody@gmail.com>
Subject: Re: [PATCH nft V2] hash: generate a random seed if seed option is empty
Date: Sat, 15 Apr 2017 11:31:33 +0200 [thread overview]
Message-ID: <20170415093133.GA5465@salvia> (raw)
In-Reply-To: <1492248137-13776-1-git-send-email-zlpnobody@163.com>
On Sat, Apr 15, 2017 at 05:22:17PM +0800, Liping Zhang wrote:
> From: Liping Zhang <zlpnobody@gmail.com>
>
> Typing the "nft add rule x y ct mark set jhash ip saddr mod 2" will
> not generate a random seed, instead, the seed will always be zero.
>
> So if seed option is empty, we shoulde not set the NFTA_HASH_SEED
> attribute, then a random seed will be generated in the kernel.
Applied, thanks Liping.
prev parent reply other threads:[~2017-04-15 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-15 9:22 [PATCH nft V2] hash: generate a random seed if seed option is empty Liping Zhang
2017-04-15 9:31 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170415093133.GA5465@salvia \
--to=pablo@netfilter.org \
--cc=laura.garcia@zevenet.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
--cc=zlpnobody@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).