From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next 1/3] netfilter: nft_ct: allow to set ctnetlink event types of a connection
Date: Sat, 15 Apr 2017 11:44:39 +0200 [thread overview]
Message-ID: <20170415094439.GB1707@breakpoint.cc> (raw)
In-Reply-To: <20170415090945.GA4023@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> I wonder if this should go in a oneliner, given this is fixing the
> fact that we may end up using the template. So someone has a chance to
> pass it to -stable. I'll be fine either way, no problem.
Ok. will do.
> > +#ifdef CONFIG_NF_CONNTRACK_EVENTS
> > + case NFT_CT_EVENTMASK: {
> > + struct nf_conntrack_ecache *e = nf_ct_ecache_find(ct);
> > + u16 ctmask = (u16)regs->data[priv->sreg];
>
> Liping added helpers to fetch data from registers, I think it
> applies to this case too.
Right, I forgot about this, thanks for noticing.
Having such huge backlog is crap, I won't do this again, ever :(
next prev parent reply other threads:[~2017-04-15 9:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-15 8:45 netfilter: nftables: ctnetlink event type set support Florian Westphal
2017-04-15 8:45 ` [PATCH nf-next 1/3] netfilter: nft_ct: allow to set ctnetlink event types of a connection Florian Westphal
2017-04-15 9:09 ` Pablo Neira Ayuso
2017-04-15 9:44 ` Florian Westphal [this message]
2017-04-15 9:50 ` Pablo Neira Ayuso
2017-04-15 8:45 ` [PATCH libnftnl 2/3] src: ct eventmask support Florian Westphal
2017-04-15 8:45 ` [PATCH nft 3/3] ct: add conntrack event mask support Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170415094439.GB1707@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).