netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthias Kaehlcke <mka@chromium.org>
To: Pablo Neira Ayuso <pablo@netfilter.org>,
	Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org
Subject: Doubt about CTA_EXPECT_* values passed to ctnetlink_parse_tuple()
Date: Mon, 17 Apr 2017 15:37:30 -0700	[thread overview]
Message-ID: <20170417223730.GR28657@google.com> (raw)

Hi,

While working on clang support for kernel builds I came across at what
at first sight looks like an enum mismatch in the netfilter conntrack
code:

In multiple occasions CTA_EXPECT_* values (of type enum ctattr_expect)
are passed to ctnetlink_parse_tuple(), which expects an 'enum
ctattr_type' as type argument.

In other cases unintentional use of a wrong enum type maybe be
obvious, in this case however it isn't clear to me which 'enum
ctattr_type' should be passed instead, so I wonder if the use of the
different type is intended.

Could someone please briefly clarify? My background on netfilter
internals is zero, so please forgive my probably naive question.

Thanks

Matthias

             reply	other threads:[~2017-04-17 22:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-17 22:37 Matthias Kaehlcke [this message]
2017-04-18  8:39 ` Doubt about CTA_EXPECT_* values passed to ctnetlink_parse_tuple() Pablo Neira Ayuso
2017-04-18 19:41   ` Matthias Kaehlcke
2017-04-18 19:43     ` Matthias Kaehlcke
2017-04-19  8:58       ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170417223730.GR28657@google.com \
    --to=mka@chromium.org \
    --cc=coreteam@netfilter.org \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).