From: Matthias Kaehlcke <mka@chromium.org>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
Matthias Kaehlcke <mka@chromium.org>
Subject: Re: Doubt about CTA_EXPECT_* values passed to ctnetlink_parse_tuple()
Date: Tue, 18 Apr 2017 12:41:16 -0700 [thread overview]
Message-ID: <20170418194116.GD128305@google.com> (raw)
In-Reply-To: <20170418083947.GA1720@salvia>
Hi Pablo,
Thanks for your reply!
El Tue, Apr 18, 2017 at 10:39:47AM +0200 Pablo Neira Ayuso ha dit:
> On Mon, Apr 17, 2017 at 03:37:30PM -0700, Matthias Kaehlcke wrote:
> > Hi,
> >
> > While working on clang support for kernel builds I came across at what
> > at first sight looks like an enum mismatch in the netfilter conntrack
> > code:
> >
> > In multiple occasions CTA_EXPECT_* values (of type enum ctattr_expect)
> > are passed to ctnetlink_parse_tuple(), which expects an 'enum
> > ctattr_type' as type argument.
>
> Are you refering to this? See patch.
Almost, see patch :)
I interpret that passing the different enum types is intentional and
changing the parameter type an acceptable solution.
Cheers
Matthias
next prev parent reply other threads:[~2017-04-18 19:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-17 22:37 Doubt about CTA_EXPECT_* values passed to ctnetlink_parse_tuple() Matthias Kaehlcke
2017-04-18 8:39 ` Pablo Neira Ayuso
2017-04-18 19:41 ` Matthias Kaehlcke [this message]
2017-04-18 19:43 ` Matthias Kaehlcke
2017-04-19 8:58 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418194116.GD128305@google.com \
--to=mka@chromium.org \
--cc=coreteam@netfilter.org \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).