From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: gfree.wind@foxmail.com, netfilter-devel@vger.kernel.org,
Gao Feng <fgao@ikuai8.com>
Subject: Re: [PATCH nf-next] netfilter: tcp: Use TCP_MAX_WSCALE instead of literal 14
Date: Wed, 19 Apr 2017 21:57:55 +0200 [thread overview]
Message-ID: <20170419195755.GA16404@salvia> (raw)
In-Reply-To: <1492618928.22296.2.camel@edumazet-glaptop3.roam.corp.google.com>
On Wed, Apr 19, 2017 at 09:22:08AM -0700, Eric Dumazet wrote:
> On Wed, 2017-04-19 at 17:58 +0200, Pablo Neira Ayuso wrote:
> > On Wed, Apr 19, 2017 at 09:23:42AM +0800, gfree.wind@foxmail.com wrote:
> > > From: Gao Feng <fgao@ikuai8.com>
> > >
> > > The window scale may be enlarged from 14 to 15 according to the itef
> > > draft https://tools.ietf.org/html/draft-nishida-tcpm-maxwin-03.
> > >
> > > Use the macro TCP_MAX_WSCALE to support it easily with TCP stack in
> > > the future.
> >
> > Applied, thanks.
>
> Note that linux kernel is not ready yet for a TCP_MAX_WSCALE being
> changed to 15.
>
> Signed 32bit sk counters can already be abused with 1GB TCP windows, for
> malicious peers sending SACK forcing linux to increase its memory usage
> above 2GB and overflows are pretty bad.
We have tend to use our own definitions for the TCP connection
tracking so far. This one I checked it refers RFC1323 too.
If this semantics may change from one way to another in a way that may
break conntracking, please let me know, I can toss it here.
Thanks Eric!
next prev parent reply other threads:[~2017-04-19 19:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 1:23 [PATCH nf-next] netfilter: tcp: Use TCP_MAX_WSCALE instead of literal 14 gfree.wind
2017-04-19 15:58 ` Pablo Neira Ayuso
2017-04-19 16:22 ` Eric Dumazet
2017-04-19 19:57 ` Pablo Neira Ayuso [this message]
2017-04-19 20:38 ` Pablo Neira Ayuso
2017-04-20 0:44 ` Gao Feng
2017-04-20 12:07 ` Eric Dumazet
2017-04-21 1:28 ` Gao Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170419195755.GA16404@salvia \
--to=pablo@netfilter.org \
--cc=eric.dumazet@gmail.com \
--cc=fgao@ikuai8.com \
--cc=gfree.wind@foxmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).