From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Subject: Re: [PATCH] netfilter: x_tables: unlock on error in xt_find_table_lock() Date: Fri, 28 Apr 2017 15:03:14 +0200 Message-ID: <20170428130314.GA26935@breakpoint.cc> References: <20170428125756.s4ycoffclspnr4zo@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Pablo Neira Ayuso , Florian Westphal , Jozsef Kadlecsik , "David S. Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, kernel-janitors@vger.kernel.org To: Dan Carpenter Return-path: Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:35934 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425931AbdD1NDk (ORCPT ); Fri, 28 Apr 2017 09:03:40 -0400 Content-Disposition: inline In-Reply-To: <20170428125756.s4ycoffclspnr4zo@mwanda> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Dan Carpenter wrote: > According to my static checker we should unlock here before the return. > That seems reasonable to me as well. Indeed, thanks for the fix! Acked-by: Florian Westphal