From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>, Florian Westphal <fw@strlen.de>,
Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH RFC] monitor: Support printing processes which caused the event
Date: Wed, 10 May 2017 19:59:20 +0200 [thread overview]
Message-ID: <20170510175920.GG16263@breakpoint.cc> (raw)
In-Reply-To: <20170510151131.GY20805@orbyte.nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> > I don't find it ugly, but alternatively we could add a new type of info
> > sent at the beginning of the commit phase (before all the table/rule etc
> > updates) and include it there.
>
> You mean as a separate netlink message? Then we would have to map that
> message to the actual notification, no? Or do you think it's sufficient
> to cache the last PID/name received and use it for the monitor messages
> until an update to them comes in?
I didn't check yet but all the notifications should contain the current
generation id and we also send a genid update after a transaction is
done so I suspect its enough to emit the name once per transaction.
next prev parent reply other threads:[~2017-05-10 17:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 10:55 [nft PATCH RFC] monitor: Support printing processes which caused the event Phil Sutter
2017-05-10 11:27 ` Florian Westphal
2017-05-10 11:38 ` Pablo Neira Ayuso
2017-05-10 11:57 ` Florian Westphal
2017-05-10 14:39 ` Phil Sutter
2017-05-10 14:54 ` Florian Westphal
2017-05-10 15:11 ` Phil Sutter
2017-05-10 17:59 ` Florian Westphal [this message]
2017-05-11 6:41 ` Pablo Neira Ayuso
2017-05-11 6:59 ` Florian Westphal
2017-05-11 8:27 ` Phil Sutter
2017-05-11 9:58 ` Pablo Neira Ayuso
2017-05-11 9:59 ` Pablo Neira Ayuso
2017-05-10 11:34 ` Pablo Neira Ayuso
2017-05-10 12:52 ` Arturo Borrero Gonzalez
2017-05-10 14:02 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170510175920.GG16263@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).