From: Pablo Neira Ayuso <pablo@netfilter.org>
To: gfree.wind@vip.163.com
Cc: stephen@networkplumber.org, fw@strlen.de,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf v2] ebtables: arpreply: Add the standard target sanity check
Date: Tue, 16 May 2017 11:43:24 +0200 [thread overview]
Message-ID: <20170516094324.GA18427@salvia> (raw)
In-Reply-To: <20170516082400.GA11114@salvia>
On Tue, May 16, 2017 at 10:24:00AM +0200, Pablo Neira Ayuso wrote:
> On Tue, May 16, 2017 at 09:30:18AM +0800, gfree.wind@vip.163.com wrote:
> > From: Gao Feng <gfree.wind@vip.163.com>
> >
> > The info->target is from userspace and it would be used directly.
> > So we need to add the sanity check to make sure it is a valid standard
> > target, although the ebtables tool has already checked it. Kernel need
> > to check anything from userspace.
> >
> > If the target was set as an evil value, it would break the ebtables
> > and cause a panic. Because the non-standard target is treated as one
> > offset.
> >
> > Now add one helper function ebt_invalid_target, and we would replace
> > the macro INVALID_TARGET later.
>
> Applied, thanks.
>
> There is a few bunch of spots that can use this indeed. Follow up with
> a patch for nf-next once merge window opens up.
Please, use:
netfilter: ...
as you initial patch subject next time...
next prev parent reply other threads:[~2017-05-16 9:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 1:30 [PATCH nf v2] ebtables: arpreply: Add the standard target sanity check gfree.wind
2017-05-16 8:24 ` Pablo Neira Ayuso
2017-05-16 9:43 ` Pablo Neira Ayuso [this message]
2017-05-16 9:53 ` Gao Feng
2017-05-16 9:55 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516094324.GA18427@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=gfree.wind@vip.163.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).