netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH v3] List handles of added rules if requested
Date: Tue, 23 May 2017 23:04:26 +0200	[thread overview]
Message-ID: <20170523210426.GA5212@salvia> (raw)
In-Reply-To: <20170519114532.4484-1-phil@nwl.cc>

On Fri, May 19, 2017 at 01:45:32PM +0200, Phil Sutter wrote:
> Being able to retrieve an added rule's handle atomically is a crucial
> feature for scripts invoking nft command: Without it, there is no way to
> be sure a handle extracted from 'nft list ruleset' command actually
> refers to the rule one has added before or that of another process which
> ran in between.
> 
> Extracting an added rule's handle itself is not an easy task already,
> since there is a chance that a given rule is printed differently than
> when it was added before. A simple example is port number vs. service
> name:
> 
> | nft add rule ip t c tcp dport { ssh, 80 } accept
> 
> There is no way to make 'nft list ruleset' return the rule just like
> this as depending on whether '-nn' was given or not, it either prints
> the set as '{ ssh, http }' or '{ 22, 80 }' but never in the mixed form
> that was used when adding it.
> 
> This patch adds the option to print an identifying string for each added
> rule which may be used as single parameter to a later 'nft delete rule'
> command. So a simple scripting example looks like this:
> 
> | handle=$(nft --echo add rule ip t c counter)
> | ...
> | nft delete rule $handle

Please, extend this so --echo consistently print the result for other
commands too. I prefer this works for all commands or none.

We should probably consider the introduction of unique handles to
table, chains, sets and objects at some point. Thus, you may request
to a specific version of the object, that if it is not available,
simply bail out. These handles would be printed with this --echo
option too.

  reply	other threads:[~2017-05-23 21:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-19 11:45 [nft PATCH v3] List handles of added rules if requested Phil Sutter
2017-05-23 21:04 ` Pablo Neira Ayuso [this message]
2017-05-23 21:05 ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170523210426.GA5212@salvia \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).