From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH 1/6 RFC] netfilter: normalize x_table function declarations Date: Wed, 24 May 2017 19:37:31 +0200 Message-ID: <20170524173731.GC7439@salvia> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Netfilter Developer Mailing List , linux-audit@redhat.com, Florian Westphal , Thomas Woerner , Thomas Graf , Eric Paris , Paul Moore , Steve Grubb To: Richard Guy Briggs Return-path: Received: from mail.us.es ([193.147.175.20]:48588 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753880AbdEXRhj (ORCPT ); Wed, 24 May 2017 13:37:39 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id BEF42DFF26 for ; Wed, 24 May 2017 19:37:30 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 9A9051021A6 for ; Wed, 24 May 2017 19:37:30 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 07BFD1021A4 for ; Wed, 24 May 2017 19:37:26 +0200 (CEST) Content-Disposition: inline In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Thu, May 18, 2017 at 01:21:47PM -0400, Richard Guy Briggs wrote: > Git context diffs were being produced with unhelpful declaration types in the > place of function names to help identify the funciton in which changes were > made. > > Normalize x_table function declarations so that git context diff function > labels work as expected. I know of people that usually complain on this cleanups, since they just add extra work to backports. But I have no major objection to this if you want to push it forward.