From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ismo Puustinen <ismo.puustinen@intel.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] tests: test include directories
Date: Tue, 6 Jun 2017 01:54:30 +0200 [thread overview]
Message-ID: <20170605235430.GD2314@salvia> (raw)
In-Reply-To: <20170605151233.1689-2-ismo.puustinen@intel.com>
On Mon, Jun 05, 2017 at 06:12:33PM +0300, Ismo Puustinen wrote:
> Add tests for:
> * including an empty directory
> * including directory with one or two files in it
> * testing for required trailing slash in directory name
> * testing for detecting non-existent directory
> * testing for a broken file in included directory
This looks good to me. Thanks for adding tests!
Will take this once we sort out comestic issues with 1/2.
next prev parent reply other threads:[~2017-06-05 23:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 15:12 [PATCH v2 1/2] scanner: add support for include directories Ismo Puustinen
2017-06-05 15:12 ` [PATCH v2 2/2] tests: test " Ismo Puustinen
2017-06-05 23:54 ` Pablo Neira Ayuso [this message]
2017-06-05 23:53 ` [PATCH v2 1/2] scanner: add support for " Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170605235430.GD2314@salvia \
--to=pablo@netfilter.org \
--cc=ismo.puustinen@intel.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).