From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ismo Puustinen <ismo.puustinen@intel.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] scanner: add support for include directories
Date: Tue, 6 Jun 2017 17:58:24 +0200 [thread overview]
Message-ID: <20170606155824.GA12447@salvia> (raw)
In-Reply-To: <20170606115010.26437-1-ismo.puustinen@intel.com>
On Tue, Jun 06, 2017 at 02:50:09PM +0300, Ismo Puustinen wrote:
> If a string after "include" keyword points to a directory instead of a
> file, consider the directory to contain only nft rule files and try to
> load them all. This helps with a use case where services drop their own
> firewall configuration files into a directory and nft needs to include
> those without knowing the exact file names.
>
> File loading order from the include directory is not specified, so the
> files inside an include directory should not depend on each other.
>
> Fixes(Bug 1154 - Allow include statement to operate on directories and/or wildcards).
Applied, thanks Ismo.
BTW, it would be great if you can send us a patch for the nft(8)
manpage too to document this new feature.
I can also create an account for your at wiki.nftables.org, in case
you want to add there more examples. There are people even slightly
describing their usecase and the way they are solving it. These
patterns will be good for people that are looking into reusing good
ideas when using nftables.
next prev parent reply other threads:[~2017-06-06 15:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 11:50 [PATCH v3 1/2] scanner: add support for include directories Ismo Puustinen
2017-06-06 11:50 ` [PATCH v3 2/2] tests: test " Ismo Puustinen
2017-06-06 15:58 ` Pablo Neira Ayuso
2017-06-06 15:58 ` Pablo Neira Ayuso [this message]
2017-06-06 16:01 ` [PATCH v3 1/2] scanner: add support for " Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606155824.GA12447@salvia \
--to=pablo@netfilter.org \
--cc=ismo.puustinen@intel.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).