From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] ct: fix inet/bridge/netdev family handling for saddr/daddr
Date: Tue, 6 Jun 2017 18:09:25 +0200 [thread overview]
Message-ID: <20170606160925.GB13625@salvia> (raw)
In-Reply-To: <20170529172538.27878-2-fw@strlen.de>
On Mon, May 29, 2017 at 07:25:38PM +0200, Florian Westphal wrote:
> "ct orignal saddr" has an invalid data type, as the address can be either ipv4 or ipv6.
> For some cases we could infer it from the rhs, but there are cases where we don't have any
> information, e.g. when passing ct original saddr to jhash expression.
>
> So do the same thing that we do for "rt nexthop" -- error out and hint to user
> they need to specifiy the desired address type with "meta nfproto".
>
> Suggested-by: Pablo Neira Ayuso <pablo@netfilter.org>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
next prev parent reply other threads:[~2017-06-06 16:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 17:25 [PATCH nft] meta: permit meta nfproto ip in ip family Florian Westphal
2017-05-29 17:25 ` [PATCH nft] ct: fix inet/bridge/netdev family handling for saddr/daddr Florian Westphal
2017-06-06 16:09 ` Pablo Neira Ayuso [this message]
2017-06-06 16:09 ` [PATCH nft] meta: permit meta nfproto ip in ip family Pablo Neira Ayuso
2017-06-06 18:57 ` Florian Westphal
2017-06-12 10:46 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606160925.GB13625@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).