From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Shyam Saini <mayhs11saini@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCHv3] tests: py: Add test for ambiguity while setting the value
Date: Sun, 18 Jun 2017 11:31:37 +0200 [thread overview]
Message-ID: <20170618093137.GA12806@salvia> (raw)
In-Reply-To: <20170618092913.GA8026@salvia>
On Sun, Jun 18, 2017 at 11:29:13AM +0200, Pablo Neira Ayuso wrote:
> On Sat, Jun 17, 2017 at 01:05:42AM +0530, Shyam Saini wrote:
> > This test checks bug identified and fixed in the commit mentioned below
> > In a statement if there are multiple src data then it would be
> > totally ambiguous to decide which value to set.
> >
> > Before the commit was made it returned 134(BUG), but now it returns 1
> > i.e, an error message.
>
> Applied, thanks.
>
> One change though before applying, see below.
>
> > Test: 986dea8 ("evaluate: avoid reference to multiple src data in
> > statements which set values")
BTW, please update .gitconfig in your home to add:
[core]
abbrev = 12
So we get commit abbrev of 12 chars at least.
7 may lead to ambiguities in the future, as a hash with the same
prefix may show up later on.
Thanks!
next prev parent reply other threads:[~2017-06-18 9:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 19:35 [PATCHv3] tests: py: Add test for ambiguity while setting the value Shyam Saini
2017-06-18 9:29 ` Pablo Neira Ayuso
2017-06-18 9:31 ` Pablo Neira Ayuso [this message]
2017-06-21 8:46 ` Shyam Saini
2017-06-18 9:48 ` Pablo Neira Ayuso
2017-06-21 8:50 ` Shyam Saini
2017-06-21 8:45 ` Shyam Saini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170618093137.GA12806@salvia \
--to=pablo@netfilter.org \
--cc=mayhs11saini@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).