From: Florian Westphal <fw@strlen.de>
To: Liping Zhang <zlpnobody@163.com>
Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org,
Liping Zhang <zlpnobody@gmail.com>,
Davide Caratti <dcaratti@redhat.com>
Subject: Re: [PATCH nf] netfilter: nf_ct_dccp/sctp: fix memory leak after netns cleanup
Date: Mon, 19 Jun 2017 17:52:38 +0200 [thread overview]
Message-ID: <20170619155238.GC28291@breakpoint.cc> (raw)
In-Reply-To: <1496575054-17168-1-git-send-email-zlpnobody@163.com>
Liping Zhang <zlpnobody@163.com> wrote:
> From: Liping Zhang <zlpnobody@gmail.com>
>
> After running the following commands for a while, kmemleak reported that
> "1879 new suspected memory leaks" happened:
> # while : ; do
> ip netns add test
> ip netns delete test
> done
Acked-by: Florian Westphal <fw@strlen.de>
I think we might want to add this to nf-next:
@@ -408,8 +410,10 @@ int nf_ct_l4proto_pernet_register_one(struct net *net,
pn = nf_ct_l4proto_net(net, l4proto);
- if (pn == NULL)
+ if (pn == NULL) {
+ ret = -EINVAL;
goto out;
+ }
so that nf_ct_l4proto_pernet_register_one() will return failure.
Maybe even add a WARN_ON in nf_ct_l4proto_net() to catch this.
next prev parent reply other threads:[~2017-06-19 15:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 11:17 [PATCH nf] netfilter: nf_ct_dccp/sctp: fix memory leak after netns cleanup Liping Zhang
2017-06-05 8:09 ` Davide Caratti
2017-06-19 15:52 ` Florian Westphal [this message]
2017-06-27 15:57 ` Pablo Neira Ayuso
2017-06-28 18:24 ` [nf] " Andrei Vagin
2017-06-28 23:36 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619155238.GC28291@breakpoint.cc \
--to=fw@strlen.de \
--cc=dcaratti@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=zlpnobody@163.com \
--cc=zlpnobody@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).