From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Oliver Ford <ojford@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/1] iptables-xml: Fix segfault on jump without a target
Date: Mon, 19 Jun 2017 19:30:41 +0200 [thread overview]
Message-ID: <20170619173041.GA29767@salvia> (raw)
In-Reply-To: <1496417677-8228-1-git-send-email-ojford@gmail.com>
On Fri, Jun 02, 2017 at 03:34:37PM +0000, Oliver Ford wrote:
> As reported in Bugzilla #1152, a segfault occurs in iptables-xml if a
> jump or goto argument lacks a target argument. The following input will
> segfault:
> *filter
> :INPUT ACCEPT [0:0]
> -A INPUT -p tcp --dport 2200 -j
>
> Problem occurs in do_rule_part, where the existsChain() function is called
> with argv[arg + 1]. If the jump/goto argument is the last argument, then
> arg + 1 is out of the array bounds. The fix ensures that arg + 1 is within
> the array bounds before the call to existsChain() is made.
Applied, thanks.
prev parent reply other threads:[~2017-06-19 17:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 15:34 [PATCH 1/1] iptables-xml: Fix segfault on jump without a target Oliver Ford
2017-06-19 17:30 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619173041.GA29767@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=ojford@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).