netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Cc: Florian Westphal <fw@strlen.de>
Subject: [PATCH lnf-queue] src: prepare for new release
Date: Wed, 21 Jun 2017 00:28:52 +0200	[thread overview]
Message-ID: <20170620222852.19879-1-fw@strlen.de> (raw)

Its been 5 years, things like GSO and NFQA_CT have been in the master
branch for years but no released versions support them.

Needs bump of libversion, we have new interfaces but are compatible with
still compatible with the earlier 1.0.2 release.

Signed-off-by: Florian Westphal <fw@strlen.de>
---
 Hi, some people are rightfully complaining about new features
 not being in any release, so I suggest we do one soon.

diff --git a/src/Makefile.am b/src/Makefile.am
index 6e5d50325525..9fdccfbd9ea5 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -18,7 +18,7 @@
 # set age to 0.
 # </snippet>
 #
-LIBVERSION=4:0:3
+LIBVERSION=5:0:4
 
 include ${top_srcdir}/Make_global.am
 
diff --git a/src/libnetfilter_queue.c b/src/libnetfilter_queue.c
index 211a8ba75d79..69db0e02fc5b 100644
--- a/src/libnetfilter_queue.c
+++ b/src/libnetfilter_queue.c
@@ -658,6 +658,7 @@ EXPORT_SYMBOL(nfq_set_mode);
  * - NFQA_CFG_F_GSO (requires Linux kernel >= 3.10): the kernel will
  *   not normalize offload packets, i.e. your application will need to
  *   be able to handle packets larger than the mtu (up to 64k).
+ *   Normalization is expensive, so this flag should always be set.
  *
  *   If your application validates checksums (e.g., tcp checksum),
  *   then you must also check if the NFQA_SKB_INFO attribute is present.
-- 
2.13.0


             reply	other threads:[~2017-06-20 22:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-20 22:28 Florian Westphal [this message]
2017-06-21 16:37 ` [PATCH lnf-queue] src: prepare for new release Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170620222852.19879-1-fw@strlen.de \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).