From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH lnf-queue] src: prepare for new release
Date: Wed, 21 Jun 2017 18:37:00 +0200 [thread overview]
Message-ID: <20170621163700.GA6437@salvia> (raw)
In-Reply-To: <20170620222852.19879-1-fw@strlen.de>
On Wed, Jun 21, 2017 at 12:28:52AM +0200, Florian Westphal wrote:
> diff --git a/src/libnetfilter_queue.c b/src/libnetfilter_queue.c
> index 211a8ba75d79..69db0e02fc5b 100644
> --- a/src/libnetfilter_queue.c
> +++ b/src/libnetfilter_queue.c
> @@ -658,6 +658,7 @@ EXPORT_SYMBOL(nfq_set_mode);
> * - NFQA_CFG_F_GSO (requires Linux kernel >= 3.10): the kernel will
> * not normalize offload packets, i.e. your application will need to
> * be able to handle packets larger than the mtu (up to 64k).
> + * Normalization is expensive, so this flag should always be set.
With this on, I see more chances to hit the netlink attribute
limitation, so packets on the 64k will be truncated?
Probably good to document this too.
prev parent reply other threads:[~2017-06-21 16:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 22:28 [PATCH lnf-queue] src: prepare for new release Florian Westphal
2017-06-21 16:37 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170621163700.GA6437@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).