From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Shyam Saini <mayhs11saini@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] tests: shell: Add test for incomplete set add set command
Date: Mon, 26 Jun 2017 18:59:42 +0200 [thread overview]
Message-ID: <20170626165942.GA8489@salvia> (raw)
In-Reply-To: <1498219556-25179-1-git-send-email-mayhs11saini@gmail.com>
On Fri, Jun 23, 2017 at 05:35:55PM +0530, Shyam Saini wrote:
> Before the [Test] commit if we run nft with incomplete "add set"
> command it caused segmentation fault and exit with error code 139 and
> further it didn't throw any error message.
>
> For example:
> $ sudo nft add set t s
>
> But after the [Test] commit it throws syntax error message and exits with
> return value 1.
>
> For example:
> $ sudo nft add set t s
> <cmdline>:1:12-12: Error: syntax error, unexpected newline, expecting '{'
> add set t s
> ^
>
> This commit tests changes made in the [Test] commit.
Applied, thanks.
I have reworked a bit your commit message, it looks a bit convoluted.
No worries, have a look at what I pushed out for reference.
next prev parent reply other threads:[~2017-06-26 16:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 12:05 [PATCH 1/2] tests: shell: Add test for incomplete set add set command Shyam Saini
2017-06-23 12:05 ` [PATCH 2/2] tests: shell: Test input descriptors for included files Shyam Saini
2017-06-26 16:59 ` Pablo Neira Ayuso
2017-06-26 16:59 ` Pablo Neira Ayuso [this message]
2017-06-26 17:32 ` [PATCH 1/2] tests: shell: Add test for incomplete set add set command Shyam Saini
2017-06-26 17:37 ` Pablo Neira Ayuso
2017-06-26 17:54 ` Shyam Saini
2017-06-26 18:08 ` Pablo Neira Ayuso
2017-06-26 18:16 ` Shyam Saini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170626165942.GA8489@salvia \
--to=pablo@netfilter.org \
--cc=mayhs11saini@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).