From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Shyam Saini <mayhs11saini@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] tests: py: Fail test forcefully when bug is not fixed
Date: Mon, 26 Jun 2017 19:24:59 +0200 [thread overview]
Message-ID: <20170626172459.GA11859@salvia> (raw)
In-Reply-To: <1498034865-11321-1-git-send-email-mayhs11saini@gmail.com>
On Wed, Jun 21, 2017 at 02:17:45PM +0530, Shyam Saini wrote:
> when we have "fail" in the test cases then py test doesn't complain
> anything, but the test should complain if the fix is not applied.
>
> Before applying the [Test] commit, nft throws following error message
> and exits with error code 134.
> $ nft add rule x y tcp dport set { 0 , 1 }
> BUG: unknown expression type set reference
> nft: netlink_linearize.c:696: netlink_gen_expr: Assertion `0' failed.
> Aborted
>
> This commit enforces nft-test.py to throw error message when the fix
> is not applied.
This also looks good, applied, thanks Shyam.
prev parent reply other threads:[~2017-06-26 17:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 8:47 [PATCH] tests: py: Fail test forcefully when bug is not fixed Shyam Saini
2017-06-26 17:24 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170626172459.GA11859@salvia \
--to=pablo@netfilter.org \
--cc=mayhs11saini@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).