From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH 1/2] tests: shell: Add test for incomplete set add set command Date: Mon, 26 Jun 2017 20:08:34 +0200 Message-ID: <20170626180834.GA12436@salvia> References: <1498219556-25179-1-git-send-email-mayhs11saini@gmail.com> <20170626165942.GA8489@salvia> <20170626173725.GA12032@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Netfilter Development Mailing list To: Shyam Saini Return-path: Received: from mail.us.es ([193.147.175.20]:34512 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751393AbdFZSIn (ORCPT ); Mon, 26 Jun 2017 14:08:43 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 089EBE7B87 for ; Mon, 26 Jun 2017 20:08:32 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id EE298DA46D for ; Mon, 26 Jun 2017 20:08:31 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id C8B6BDA7F4 for ; Mon, 26 Jun 2017 20:08:29 +0200 (CEST) Content-Disposition: inline In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Mon, Jun 26, 2017 at 11:24:23PM +0530, Shyam Saini wrote: > On Mon, Jun 26, 2017 at 11:07 PM, Pablo Neira Ayuso wrote: > > On Mon, Jun 26, 2017 at 11:02:34PM +0530, Shyam Saini wrote: > >> On Mon, Jun 26, 2017 at 10:29 PM, Pablo Neira Ayuso wrote: > >> > On Fri, Jun 23, 2017 at 05:35:55PM +0530, Shyam Saini wrote: > >> >> Before the [Test] commit if we run nft with incomplete "add set" > >> >> command it caused segmentation fault and exit with error code 139 and > >> >> further it didn't throw any error message. > >> >> > >> >> For example: > >> >> $ sudo nft add set t s > >> >> > >> >> But after the [Test] commit it throws syntax error message and exits with > >> >> return value 1. > >> >> > >> >> For example: > >> >> $ sudo nft add set t s > >> >> :1:12-12: Error: syntax error, unexpected newline, expecting '{' > >> >> add set t s > >> >> ^ > >> >> > >> >> This commit tests changes made in the [Test] commit. > >> > > >> > Applied, thanks. > >> > > >> > I have reworked a bit your commit message, it looks a bit convoluted. > >> > >> Thanks a lot :) > >> > >> > No worries, have a look at what I pushed out for reference. > >> > >> Shouldn't we follow conventions mentioned in "scripts/checkpatch.pl" ? > > > > Interesting. > > > > So the [test] thing is something that checkpatch.pl suggests, right? > yes something like that. > > > I would like to know more about that new thing, do you have > > documentation about this? > > No documentation but yeah it throws following error when convention is > not followed. > > "ERROR: Please use git commit description style 'commit <12+ chars of > sha1> ("")' - ie: 'commit c6cd7c22548a ("src: fix crash > when inputting an incomplete set add command")'" Ah, that's different thing. so no need for the [Test] tag you are adding. This means that: commit c6cd7c22548a ("src: fix crash when inputting an incomplete set add command") is the right way to refer to commits. That's a valid thing indeed, we should stick to that. Let's stick to this in follow up patches, OK?