netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Leblond <eric@regit.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH libnfntl] set: free user data
Date: Thu, 6 Jul 2017 15:49:53 +0200	[thread overview]
Message-ID: <20170706134953.GA7766@salvia> (raw)
In-Reply-To: <20170706130539.22515-1-eric@regit.org>

On Thu, Jul 06, 2017 at 02:05:39PM +0100, Eric Leblond wrote:
> This was causing a memory leak when using set.
> 
> Catched by an ASAN run:
> 
> ==21004==ERROR: LeakSanitizer: detected memory leaks
> 
> Direct leak of 12 byte(s) in 2 object(s) allocated from:
>     #0 0x4cde58 in malloc (/usr/local/sbin/nft+0x4cde58)
>     #1 0x7ffff79b8c19 in nftnl_set_set_data /home/eric/git/netfilter/libnftnl/src/set.c:179
> 
> Signed-off-by: Eric Leblond <eric@regit.org>

Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>

Please go push this, thanks!

      reply	other threads:[~2017-07-06 13:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-06 13:05 [PATCH libnfntl] set: free user data Eric Leblond
2017-07-06 13:49 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170706134953.GA7766@salvia \
    --to=pablo@netfilter.org \
    --cc=eric@regit.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).