netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org,
	Arturo Borrero Gonzalez <arturo@netfilter.org>
Subject: [nft PATCH 0/4] monitor: Fix printing of range elements in named sets
Date: Wed, 12 Jul 2017 14:36:54 +0200	[thread overview]
Message-ID: <20170712123658.25363-1-phil@nwl.cc> (raw)

As agreed upon with Arturo at NFWS, here is my version of the same fix
for side-by-side comparison.

This series allows 'nft monitor' to correctly reassemble ranges before
printing them, also in the case of half-open ranges (used when a range
spans to the end of the spectrum).

To fix the zero segment problem, the last patch in this series has to
retrieve the parsed set element from dummyset. For convenience, I
created list_last_entry() macro and compound_expr_last() as shown in
patches 2 and 3.

Phil Sutter (4):
  monitor: Fix printing of range elements in named sets
  list: Introduce list_last_entry
  expression: Introduce compound_expr_last
  monitor: Ignore ranges' zero segment

 include/expression.h |  1 +
 include/list.h       | 11 ++++++++
 src/expression.c     |  7 +++++
 src/netlink.c        | 80 +++++++++++++++++++++++++++++++++++++++++++++++++---
 4 files changed, 95 insertions(+), 4 deletions(-)

-- 
2.13.1


             reply	other threads:[~2017-07-12 12:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-12 12:36 Phil Sutter [this message]
2017-07-12 12:36 ` [nft PATCH 1/4] monitor: Fix printing of range elements in named sets Phil Sutter
2017-07-12 16:30   ` Arturo Borrero Gonzalez
2017-07-12 19:05     ` Phil Sutter
2017-07-13 18:22       ` Phil Sutter
2017-07-14  9:03         ` Arturo Borrero Gonzalez
2017-07-17 16:12         ` Pablo Neira Ayuso
2017-07-17 17:02           ` Phil Sutter
2017-07-12 12:36 ` [nft PATCH 2/4] list: Introduce list_last_entry Phil Sutter
2017-07-12 15:41   ` Arturo Borrero Gonzalez
2017-07-12 19:15     ` Phil Sutter
2017-07-12 12:36 ` [nft PATCH 3/4] expression: Introduce compound_expr_last Phil Sutter
2017-07-12 15:42   ` Arturo Borrero Gonzalez
2017-07-12 12:36 ` [nft PATCH 4/4] monitor: Ignore ranges' zero segment Phil Sutter
2017-07-12 15:49   ` Arturo Borrero Gonzalez
2017-07-12 19:11     ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170712123658.25363-1-phil@nwl.cc \
    --to=phil@nwl.cc \
    --cc=arturo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).