From: Florian Westphal <fw@strlen.de>
To: Richard Weinberger <richard@nod.at>
Cc: Florian Westphal <fw@strlen.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Pablo Neira Ayuso <pablo@netfilter.org>,
David Miller <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
David Gstir <david@sigma-star.at>,
kaber@trash.net, "keescook@chromium.org" <keescook@chromium.org>
Subject: Re: nf_conntrack: Infoleak via CTA_ID and CTA_EXPECT_ID
Date: Thu, 13 Jul 2017 00:19:35 +0200 [thread overview]
Message-ID: <20170712221935.GC12347@breakpoint.cc> (raw)
In-Reply-To: <1daf1401-5009-df1c-a77a-a271811c0760@nod.at>
Richard Weinberger <richard@nod.at> wrote:
> Am 01.07.2017 um 12:35 schrieb Florian Westphal:
> > The compare on removal is not needed afaics, and its also not used when
> > doing lookup to begin with, so we can just recompute it?
>
> Isn't this a way too much overhead?
I don't think so. This computation only occurs when we dump events
to userspace.
> I personally favor Pablo's per-cpu counter approach.
> That way the IDs are unique again and we get rid of the info leak without
> much effort.
I have not seen these patches so can't really comment.
prev parent reply other threads:[~2017-07-12 22:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 19:25 nf_conntrack: Infoleak via CTA_ID and CTA_EXPECT_ID Richard Weinberger
2017-06-30 19:35 ` Florian Westphal
2017-06-30 19:45 ` Richard Weinberger
2017-06-30 19:55 ` Florian Westphal
2017-06-30 20:23 ` Richard Weinberger
2017-07-01 9:44 ` Pablo Neira Ayuso
2017-07-01 10:35 ` Florian Westphal
2017-07-12 21:26 ` Richard Weinberger
2017-07-12 22:19 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170712221935.GC12347@breakpoint.cc \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=david@sigma-star.at \
--cc=kaber@trash.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).