From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Varsha Rao <rvarsha016@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft v4] include: Remove __init and __exit macro definitions.
Date: Mon, 17 Jul 2017 14:26:07 +0200 [thread overview]
Message-ID: <20170717122607.GA7416@salvia> (raw)
In-Reply-To: <59601b38.05c2620a.1b29f.4776@mx.google.com>
On Sat, Jul 08, 2017 at 05:07:23AM +0530, Varsha Rao wrote:
> Add nft_init and nft_exit functions, which calls _init and _exit
> functions in main.c file. Remove __init and __exit macro definitions as
> libnftables library will be created soon. Rename realm_table_init() and
> realm_table_exit() functions to avoid ambiguity as
> realm_table_rt_init(), realm_table_meta_init, realm_table_rt_exit() and
> realm_table_meta_exit() in rt.c and meta.c files.
Applied with changes.
Please, next time, split your patches into logical changes. In this
patch that are two logical changes that are not related:
1) Pass nf_sock to functions as parameter.
2) Remove __init and __exit functions.
So I have split this patch in two before pushing out.
Just note for the next time, no problem.
Thanks Varsha.
prev parent reply other threads:[~2017-07-17 12:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 23:37 [PATCH nft v4] include: Remove __init and __exit macro definitions Varsha Rao
2017-07-17 12:26 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170717122607.GA7416@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=rvarsha016@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).