From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jiri Slaby <jslaby@suse.cz>
Cc: linux-kernel@vger.kernel.org, Gao Feng <fgao@ikuai8.com>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org
Subject: Re: [PATCH 1/1] netfilter: nf_ct_expect: fix expect removal
Date: Mon, 17 Jul 2017 17:17:45 +0200 [thread overview]
Message-ID: <20170717151745.GA25741@salvia> (raw)
In-Reply-To: <20170717150648.10058-1-jslaby@suse.cz>
Hi Jiri,
On Mon, Jul 17, 2017 at 05:06:48PM +0200, Jiri Slaby wrote:
> Commit ec0e3f01114a ("netfilter: nf_ct_expect: Add
> nf_ct_remove_expect()") introduced a helper nf_ct_remove_expect. It was
> used over the code, but one location used a wrong variable and it
> resulted in a crash in this call stack:
> -> nf_ct_expect_related_report
> -> nf_ct_remove_expect
> -> del_timer
> -> detach_if_pending
>
> Switch to the proper variable.
>
> Fixes: ec0e3f01114a
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
I have pushed out a similar fix from Florian:
https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git/commit/?id=36ac344e16e04e3e55e8fed7446095a6458c64e6
Thanks for the fix anyway.
prev parent reply other threads:[~2017-07-17 15:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 15:06 [PATCH 1/1] netfilter: nf_ct_expect: fix expect removal Jiri Slaby
2017-07-17 15:17 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170717151745.GA25741@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=fgao@ikuai8.com \
--cc=fw@strlen.de \
--cc=jslaby@suse.cz \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).