From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>,
Arturo Borrero Gonzalez <arturo@netfilter.org>,
Netfilter Development Mailing list
<netfilter-devel@vger.kernel.org>
Subject: Re: [nft PATCH 1/4] monitor: Fix printing of range elements in named sets
Date: Mon, 17 Jul 2017 18:12:34 +0200 [thread overview]
Message-ID: <20170717161234.GA32725@salvia> (raw)
In-Reply-To: <20170713182202.GK16375@orbyte.nwl.cc>
On Thu, Jul 13, 2017 at 08:22:02PM +0200, Phil Sutter wrote:
> Just a quick status update: It's a mess. ;)
OK, let's address problems one by one.
> There are so many different cases, I actually started drawing flow
> diagrams (can't remember when I did that last time). In addition to what
> we discussed already, I realized that via 'nft -f', I can make multiple
> changes to even different sets within a single transaction - this
> requires dealing with cached half-open ranges everywhere, not just in
> NEWGEN callback.
half-open ranges always start by a NFT_SET_ELEM_INTERVAL_END flag set
on, eg.
# nft --debug=netlink add element x y { 5-65535 }
element 00000000 : 1 [end] element 00000500 : 0 [end]
> Another trap is 'nft flush set': The elements are reported in
> reverse order.
Could you have a look at the function to order elements using the
mergesort function? It's currently only called for non-intervals by
now, so it would be good to converge to use it in all cases.
Anything else?
next prev parent reply other threads:[~2017-07-17 16:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 12:36 [nft PATCH 0/4] monitor: Fix printing of range elements in named sets Phil Sutter
2017-07-12 12:36 ` [nft PATCH 1/4] " Phil Sutter
2017-07-12 16:30 ` Arturo Borrero Gonzalez
2017-07-12 19:05 ` Phil Sutter
2017-07-13 18:22 ` Phil Sutter
2017-07-14 9:03 ` Arturo Borrero Gonzalez
2017-07-17 16:12 ` Pablo Neira Ayuso [this message]
2017-07-17 17:02 ` Phil Sutter
2017-07-12 12:36 ` [nft PATCH 2/4] list: Introduce list_last_entry Phil Sutter
2017-07-12 15:41 ` Arturo Borrero Gonzalez
2017-07-12 19:15 ` Phil Sutter
2017-07-12 12:36 ` [nft PATCH 3/4] expression: Introduce compound_expr_last Phil Sutter
2017-07-12 15:42 ` Arturo Borrero Gonzalez
2017-07-12 12:36 ` [nft PATCH 4/4] monitor: Ignore ranges' zero segment Phil Sutter
2017-07-12 15:49 ` Arturo Borrero Gonzalez
2017-07-12 19:11 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170717161234.GA32725@salvia \
--to=pablo@netfilter.org \
--cc=arturo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).