From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phil Sutter Subject: Re: [nft PATCH 1/2] monitor: Rewrite SETELEM callback Date: Mon, 17 Jul 2017 18:41:14 +0200 Message-ID: <20170717164114.GR16375@orbyte.nwl.cc> References: <20170717150606.32097-1-phil@nwl.cc> <20170717150606.32097-2-phil@nwl.cc> <20170717163018.GA1244@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org, Arturo Borrero Gonzalez To: Pablo Neira Ayuso Return-path: Received: from orbyte.nwl.cc ([151.80.46.58]:41983 "EHLO mail.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbdGQQlQ (ORCPT ); Mon, 17 Jul 2017 12:41:16 -0400 Content-Disposition: inline In-Reply-To: <20170717163018.GA1244@salvia> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Mon, Jul 17, 2017 at 06:30:18PM +0200, Pablo Neira Ayuso wrote: > On Mon, Jul 17, 2017 at 05:06:05PM +0200, Phil Sutter wrote: > [...] > > +static int netlink_events_setelem_newgen_cb(const struct nlmsghdr *nlh, > > + int type, > > + struct netlink_mon_handler *monh) > > +{ > > + setelem_cache_print_default(monh); > > + > > + return MNL_CB_OK; > > } > > I would really like we don't rely on newgen for this. If there is no > way to catch a case with the existing way we represent this, then we > probably need to fix things from the kernel. > > Before we follow that patch, I would like to understand what corner > case is pushing us to use the newgen event. It is required for half-open ranges occurring at the end of the transaction: For those, we only get a single element without EXPR_F_INTERVAL_END flag set. Since this could also be the first part of a regular range, monitor has to wait for what's next - which is in doubt only the NEWGEN message. Maybe we could introduce a new flag to mark these? Cheers, Phil