[PATCH] libnetfilter_conntrack: bump version to 1.0.7

[PATCH] libnetfilter_conntrack: bump version to 1.0.7

[Richard Weinberger]

This is a maintenance release, so the version is just bumped to 1.0.7.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
Hi!

Can we please do a new release such that distros can pick it up?
My users suffer from issues which are solved by commit:
commit b0a7cf7f050fb99ead1d745a8c928310e3403bd0
Author: Pablo Neira Ayuso <pablo@netfilter.org>
Date:   Thu Nov 24 14:09:34 2016 +0100

    include: expose a copy of nf_conntrack_common.h

Thanks,
//richard
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 70dc23e84502..6304543eca7c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,6 +1,6 @@
 dnl Process this file with autoconf to create configure.
 
-AC_INIT([libnetfilter_conntrack], [1.0.6])
+AC_INIT([libnetfilter_conntrack], [1.0.7])
 AC_CONFIG_AUX_DIR([build-aux])
 AC_CANONICAL_HOST
 AC_CONFIG_HEADER([config.h])
-- 
2.12.3

Re: [PATCH] libnetfilter_conntrack: bump version to 1.0.7

[Pablo Neira Ayuso]

On Mon, Jul 10, 2017 at 10:33:50PM +0200, Richard Weinberger wrote:
> This is a maintenance release, so the version is just bumped to 1.0.7.

Applied, thanks.

P.S: I have also updated libversion, so I have mangled this patch.

Re: [PATCH] libnetfilter_conntrack: bump version to 1.0.7

[Richard Weinberger]

Pablo,

Am 17.07.2017 um 17:40 schrieb Pablo Neira Ayuso:
> On Mon, Jul 10, 2017 at 10:33:50PM +0200, Richard Weinberger wrote:
>> This is a maintenance release, so the version is just bumped to 1.0.7.
> 
> Applied, thanks.
> 
> P.S: I have also updated libversion, so I have mangled this patch.

I thought about this but didn't since the version change to 1.0.5 also
didn't not and AFAICT the interface didn't change.

In order to avoid future overhead for you, what are the rules regarding
libversion updates?

Thanks,
//richard

Re: [PATCH] libnetfilter_conntrack: bump version to 1.0.7

[Pablo Neira Ayuso]

On Mon, Jul 17, 2017 at 05:57:58PM +0200, Richard Weinberger wrote:
> Pablo,
> 
> Am 17.07.2017 um 17:40 schrieb Pablo Neira Ayuso:
> > On Mon, Jul 10, 2017 at 10:33:50PM +0200, Richard Weinberger wrote:
> >> This is a maintenance release, so the version is just bumped to 1.0.7.
> > 
> > Applied, thanks.
> > 
> > P.S: I have also updated libversion, so I have mangled this patch.
> 
> I thought about this but didn't since the version change to 1.0.5 also
> didn't not and AFAICT the interface didn't change.
>
> In order to avoid future overhead for you, what are the rules regarding
> libversion updates?

IIRC, we should always bump current and version even if no changes
happen. Rules are here:

http://git.netfilter.org/libmnl/tree/Make_global.am

P.S: If I did not do it for 1.0.5, that was my fault, sorry.

Re: [PATCH] libnetfilter_conntrack: bump version to 1.0.7

[Richard Weinberger]

Pablo,

Am 17.07.2017 um 18:03 schrieb Pablo Neira Ayuso:
> On Mon, Jul 17, 2017 at 05:57:58PM +0200, Richard Weinberger wrote:
>> Pablo,
>>
>> Am 17.07.2017 um 17:40 schrieb Pablo Neira Ayuso:
>>> On Mon, Jul 10, 2017 at 10:33:50PM +0200, Richard Weinberger wrote:
>>>> This is a maintenance release, so the version is just bumped to 1.0.7.
>>>
>>> Applied, thanks.
>>>
>>> P.S: I have also updated libversion, so I have mangled this patch.
>>
>> I thought about this but didn't since the version change to 1.0.5 also
>> didn't not and AFAICT the interface didn't change.
>>
>> In order to avoid future overhead for you, what are the rules regarding
>> libversion updates?
> 
> IIRC, we should always bump current and version even if no changes
> happen. Rules are here:
> 
> http://git.netfilter.org/libmnl/tree/Make_global.am

Good to know!

Thanks,
//richard

Re: [PATCH] libnetfilter_conntrack: bump version to 1.0.7

[Jan Engelhardt]

On Monday 2017-07-17 18:03, Pablo Neira Ayuso wrote:
>
>IIRC, we should always bump current and version even if no changes
>happen. Rules are here:
>
>http://git.netfilter.org/libmnl/tree/Make_global.am

If I read those rules correctly -

 "If any interfaces have been added"

- then, since no interface was added, removed, or otherwise modified, no bump
is the right thing.

Re: [PATCH] libnetfilter_conntrack: bump version to 1.0.7

[Pablo Neira Ayuso]

On Mon, Jul 17, 2017 at 06:28:48PM +0200, Jan Engelhardt wrote:
> 
> On Monday 2017-07-17 18:03, Pablo Neira Ayuso wrote:
> >
> >IIRC, we should always bump current and version even if no changes
> >happen. Rules are here:
> >
> >http://git.netfilter.org/libmnl/tree/Make_global.am
> 
> If I read those rules correctly -
> 
>  "If any interfaces have been added"
> 
> - then, since no interface was added, removed, or otherwise modified, no bump
> is the right thing.

Right, after another read, it seems bump is unnecessary.

So I'm taking Richard's patch as is.

Re: [PATCH] libnetfilter_conntrack: bump version to 1.0.7

[Richard Weinberger]

Pablo,

Am 17.07.2017 um 19:21 schrieb Pablo Neira Ayuso:
> On Mon, Jul 17, 2017 at 06:28:48PM +0200, Jan Engelhardt wrote:
>>
>> On Monday 2017-07-17 18:03, Pablo Neira Ayuso wrote:
>>>
>>> IIRC, we should always bump current and version even if no changes
>>> happen. Rules are here:
>>>
>>> http://git.netfilter.org/libmnl/tree/Make_global.am
>>
>> If I read those rules correctly -
>>
>>  "If any interfaces have been added"
>>
>> - then, since no interface was added, removed, or otherwise modified, no bump
>> is the right thing.
> 
> Right, after another read, it seems bump is unnecessary.
> 
> So I'm taking Richard's patch as is.

Is it on purpose that there is still no 1.0.7 release?
Same question for libnetfilter_queue 1.0.3.

Thanks,
//richard