From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org,
Arturo Borrero Gonzalez <arturo@netfilter.org>
Subject: Re: [nft PATCH v3 2/3] monitor: Fix printing of range elements in named sets
Date: Wed, 19 Jul 2017 20:22:49 +0200 [thread overview]
Message-ID: <20170719182249.GD16375@orbyte.nwl.cc> (raw)
In-Reply-To: <20170719171736.GB18828@salvia>
On Wed, Jul 19, 2017 at 07:17:36PM +0200, Pablo Neira Ayuso wrote:
> On Wed, Jul 19, 2017 at 03:05:28PM +0200, Phil Sutter wrote:
> > diff --git a/include/rule.h b/include/rule.h
> > index a25e99bdf4cfd..6acd5fa810ef5 100644
> > --- a/include/rule.h
> > +++ b/include/rule.h
> > @@ -217,6 +217,7 @@ extern struct rule *rule_lookup(const struct chain *chain, uint64_t handle);
> > * @datalen: mapping data len
> > * @objtype: mapping object type
> > * @init: initializer
> > + * @rg_cache: cached range element (left)
>
> Just a side note. This field is very much exclusive to event monitor
> printing, I would prefer this is cached somewhere else, away from the
> structure, if possible.
My solution was to make dummyset static and use it as a cache. Would
that be acceptible? I went with Arturo's solution since you seemed to
appreciate it and I didn't want to "steal" his credit. :)
Cheers, Phil
next prev parent reply other threads:[~2017-07-19 18:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 13:05 [nft PATCH v4 0/3] Fix printing of range elements in named sets Phil Sutter
2017-07-19 13:05 ` [nft PATCH v2 1/3] segtree: Introduce flag for half-open range elements Phil Sutter
2017-07-19 13:05 ` [nft PATCH v3 2/3] monitor: Fix printing of range elements in named sets Phil Sutter
2017-07-19 17:17 ` Pablo Neira Ayuso
2017-07-19 18:22 ` Phil Sutter [this message]
2017-07-19 13:05 ` [nft PATCH v2 3/3] tests: Add basic monitor testing framework Phil Sutter
2017-07-19 17:16 ` [nft PATCH v4 0/3] Fix printing of range elements in named sets Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170719182249.GD16375@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=arturo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).