From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: expect: add to hash table after expect init
Date: Mon, 24 Jul 2017 12:20:44 +0200 [thread overview]
Message-ID: <20170724102044.GA4608@salvia> (raw)
In-Reply-To: <20170710130639.24167-1-fw@strlen.de>
On Mon, Jul 10, 2017 at 03:06:39PM +0200, Florian Westphal wrote:
> assuming we have lockless readers we should make sure they can only
> see expectations that have already been initialized.
>
> hlist_add_head_rcu acts as memory barrier, move it after timer setup.
>
> Theoretically we could crash due to a del_timer() on other cpu
> seeing garbage data.
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> Not seen in practice, however i think this race
> is real. Defer to nf-next if you think its not urgent.
Applied to nf-next, thanks!
prev parent reply other threads:[~2017-07-24 10:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 13:06 [PATCH nf] netfilter: expect: add to hash table after expect init Florian Westphal
2017-07-24 10:20 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170724102044.GA4608@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).