From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: [nf-next PATCH v2 0/5] netfilter: nf_tables: Kill name length restrictions
Date: Mon, 24 Jul 2017 20:56:46 +0200 [thread overview]
Message-ID: <20170724185651.24063-1-phil@nwl.cc> (raw)
The following series removes the hard-coded restriction on name length
of tables, chains, sets and objects.
The first patch introduces nla_strdup() which aids in duplicating a
string contained in a netlink attribute. It is used to replace the call
to nla_strlcpy() when populating name fields.
I've tested the series manually by creating tables, chains, sets and
counter objects with long names and automated by running the py and
shell testsuites of nftables repo. Also, kmemleak did not find anything
nftables related.
Changes since v1:
- Introduce NFT_NAME_MAXLEN as an upper boundary to restrict overly long
names but still allow to use e.g. domain names.
- Adjust commit messages accordingly.
Phil Sutter (5):
networking: Introduce nla_strdup()
netfilter: nf_tables: Unlimit table name length
netfilter: nf_tables: Unlimit chain name length
netfilter: nf_tables: Unlimit set name length
netfilter: nf_tables: Unlimit object name length
include/net/netfilter/nf_tables.h | 10 +--
include/net/netlink.h | 1 +
include/uapi/linux/netfilter/nf_tables.h | 5 +-
lib/nlattr.c | 24 ++++++
net/netfilter/nf_tables_api.c | 136 ++++++++++++++++++++++---------
net/netfilter/nf_tables_trace.c | 10 ++-
net/netfilter/nft_dynset.c | 2 +-
net/netfilter/nft_lookup.c | 2 +-
net/netfilter/nft_objref.c | 4 +-
9 files changed, 139 insertions(+), 55 deletions(-)
--
2.13.1
next reply other threads:[~2017-07-24 18:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 18:56 Phil Sutter [this message]
2017-07-24 18:56 ` [nf-next PATCH v2 1/5] networking: Introduce nla_strdup() Phil Sutter
2017-07-24 18:56 ` [nf-next PATCH v2 2/5] netfilter: nf_tables: Unlimit table name length Phil Sutter
2017-07-25 16:10 ` Pablo Neira Ayuso
2017-07-25 19:16 ` Phil Sutter
2017-07-27 9:32 ` Pablo Neira Ayuso
2017-07-24 18:56 ` [nf-next PATCH v2 3/5] netfilter: nf_tables: Unlimit chain " Phil Sutter
2017-07-24 18:56 ` [nf-next PATCH v2 4/5] netfilter: nf_tables: Unlimit set " Phil Sutter
2017-07-24 18:56 ` [nf-next PATCH v2 5/5] netfilter: nf_tables: Unlimit object " Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170724185651.24063-1-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).