From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: [nft PATCH 1/6] tests/monitor: Ignore newgen messages in output
Date: Tue, 25 Jul 2017 16:56:24 +0200 [thread overview]
Message-ID: <20170725145629.20974-2-phil@nwl.cc> (raw)
In-Reply-To: <20170725145629.20974-1-phil@nwl.cc>
Predicting the new ID value is not feasible and neither is implementing
support for regular expressions when matching monitor output, so simply
ignore them.
Also use diff option '-w' instead of '-Z' to ignore all whitespace, not
just at EOL.
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
tests/monitor/run-tests.sh | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tests/monitor/run-tests.sh b/tests/monitor/run-tests.sh
index 7447adf1febd6..e21ed6880bc13 100755
--- a/tests/monitor/run-tests.sh
+++ b/tests/monitor/run-tests.sh
@@ -10,6 +10,9 @@ fi
trap "rm -rf $testdir" EXIT
nft=../../src/nft
+mydiff() {
+ diff -w -I '^# ' "$@"
+}
command_file=$(mktemp -p $testdir)
output_file=$(mktemp -p $testdir)
@@ -35,9 +38,9 @@ run_test() {
sleep 0.5
kill $monitor_pid
wait >/dev/null 2>&1
- if ! diff -Z -q $monitor_output $output_file >/dev/null 2>&1; then
+ if ! mydiff -q $monitor_output $output_file >/dev/null 2>&1; then
echo "monitor output differs!"
- diff -Z -u $output_file $monitor_output
+ mydiff -u $output_file $monitor_output
exit 1
fi
rm $command_file
--
2.13.1
next prev parent reply other threads:[~2017-07-25 14:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 14:56 [nft PATCH 0/6] monitor: Some fixes and improvements Phil Sutter
2017-07-25 14:56 ` Phil Sutter [this message]
2017-07-25 15:57 ` [nft PATCH 1/6] tests/monitor: Ignore newgen messages in output Pablo Neira Ayuso
2017-07-25 14:56 ` [nft PATCH 2/6] monitor: Fix printing of set declarations Phil Sutter
2017-07-25 15:57 ` Pablo Neira Ayuso
2017-07-25 17:09 ` Phil Sutter
2017-07-26 11:18 ` Pablo Neira Ayuso
2017-07-26 13:19 ` Phil Sutter
2017-07-25 14:56 ` [nft PATCH 3/6] tests/monitor: Simplify testcases Phil Sutter
2017-07-25 16:02 ` Pablo Neira Ayuso
2017-07-25 16:12 ` Pablo Neira Ayuso
2017-07-25 14:56 ` [nft PATCH 4/6] monitor: Print space after semicolon Phil Sutter
2017-07-25 16:03 ` Pablo Neira Ayuso
2017-07-25 14:56 ` [nft PATCH 5/6] tests/monitor: Clear ruleset after testing Phil Sutter
2017-07-25 16:03 ` Pablo Neira Ayuso
2017-07-25 14:56 ` [nft PATCH 6/6] tests/monitor: Add a small README Phil Sutter
2017-07-25 16:18 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725145629.20974-2-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).